Sun icon missing everywhere except En Header - Add it #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
All the tests are failing. Looks like ruby version error? This PR should only be a single commit but those 5 merges are tacked on for some reason. Maybe it's related to those.... Edit: I see it's actually #1566 |
bjohansebas
added a commit
to bjohansebas/expressjs.com-fork
that referenced
this pull request
Aug 12, 2024
|
#1566 was merged, but tests are still failing. @chrisdel101 I wonder if a trivial commit to this fork/branch might re-run the tests so they would now pass? |
|
Seems fixed after a full re-merge with main. |
carlosstenzel
approved these changes
Aug 31, 2024
crandmck
approved these changes
Sep 2, 2024
|
Thanks again @chrisdel101 ! |
chrisdel101
added a commit
to chrisdel101/expressjs.com
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sun icon was only added to English. Might as well add it to the entire site.
Also moon icon was 2x size originally and was changed. Re-add the 2x since it looks better.
Changes here should only be the addition of the sun icon to every header file.